-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Introduce nav tags #6540
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
packages/web-runtime/src/components/SidebarNav/SidebarNavItem.vue
Outdated
Show resolved
Hide resolved
packages/web-runtime/src/components/SidebarNav/SidebarNavItem.vue
Outdated
Show resolved
Hide resolved
Results for oc10SharingIntUsers3 https://drone.owncloud.com/owncloud/web/23356/31/1 💥 The acceptance tests pipeline failed. The build has been cancelled. |
08c6ad4
to
1d813c9
Compare
@@ -10,8 +10,11 @@ | |||
:data-nav-id="index" | |||
:data-nav-name="navName" | |||
> | |||
<oc-icon :name="icon" :fill-type="fillType" /> | |||
<span class="oc-ml-m text" :class="{ 'text-invisible': collapsed }" v-text="name" /> | |||
<span class="oc-flex"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just rebased to get CI green but then figured this small change here perhaps breaks selectors in the acceptance tests. I'll fix them locally and then push to the branch
Results for oc10SharingIntUsers3 https://drone.owncloud.com/owncloud/web/23381/31/1 |
Results for oC10Resharing https://drone.owncloud.com/owncloud/web/23381/22/1 |
Results for oC10SharingIntUsers2 https://drone.owncloud.com/owncloud/web/23381/30/1 |
Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23381/69/1 |
Results for oC10SharingAndTrashbin https://drone.owncloud.com/owncloud/web/23381/33/1 |
Results for oC10Files4 https://drone.owncloud.com/owncloud/web/23381/19/1 |
Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/23381/68/1 |
Results for oC10Sharing2 https://drone.owncloud.com/owncloud/web/23381/24/1 |
Results for oCISFiles2 https://drone.owncloud.com/owncloud/web/23381/56/1 |
Results for oCISSharingInternal3 https://drone.owncloud.com/owncloud/web/23381/61/1 |
Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23381/67/1 |
Results for oC10Files1 https://drone.owncloud.com/owncloud/web/23381/16/1 |
Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/23381/36/1 |
Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/23381/37/1 |
Results for oc10SharingIntUsers3 https://drone.owncloud.com/owncloud/web/23385/31/1 |
Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/23399/36/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingPublicBasic-publicLinkEdit_feature-L101.pngwebUISharingPublicBasic-publicLinkEdit_feature-L115.pngwebUISharingPublicBasic-publicLinkEdit_feature-L207.pngwebUISharingPublicBasic-publicLinkPublicActions_feature-L18.png |
Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/23399/37/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L114.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L149.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L181.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L221.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L257.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L266.pngwebUISharingPublicManagement-shareByPublicLink_feature-L19.pngwebUISharingPublicManagement-sharingPublicSession_feature-L10.pngwebUISharingPublicManagement-sharingPublicSession_feature-L20.pngwebUISharingPublicManagement-sharingPublicSession_feature-L28.pngwebUISharingPublicManagement-sharingPublicSession_feature-L35.pngwebUISharingPublicManagement-sharingPublicSession_feature-L48.png |
b2cc205
to
1ffc38f
Compare
@@ -231,6 +231,8 @@ function getMountedWrapper(spaceResources = [], spaceItem = null, imageContent = | |||
$client: { | |||
files: { | |||
getFileContents: jest.fn().mockImplementation(() => Promise.resolve('filecontent')), | |||
// TODO: Add & reference space fixtures in line below |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janackermann there's some test warnings about not being able to access the fileInfo
in the view. I think it'd make a lot of sense to add spaces fixtures and import them here
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23406/10/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23406/tracing/alice-shares-file-to-brian-alice-2022-3-8-04-21-59.zip |
Results for oC10Upload https://drone.owncloud.com/owncloud/web/23407/38/1 |
Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/23407/66/1 |
Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23407/67/1
💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingPublicBasic-publicLinkEdit_feature-L101.pngwebUISharingPublicBasic-publicLinkEdit_feature-L115.pngwebUISharingPublicBasic-publicLinkEdit_feature-L207.pngwebUISharingPublicBasic-publicLinkPublicActions_feature-L18.png |
Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/23407/36/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingPublicBasic-publicLinkEdit_feature-L101.pngwebUISharingPublicBasic-publicLinkEdit_feature-L115.pngwebUISharingPublicBasic-publicLinkEdit_feature-L207.pngwebUISharingPublicBasic-publicLinkPublicActions_feature-L18.png |
Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/23407/68/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L114.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L149.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L181.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L221.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L257.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L266.pngwebUISharingPublicManagement-shareByPublicLink_feature-L19.pngwebUISharingPublicManagement-sharingPublicSession_feature-L10.pngwebUISharingPublicManagement-sharingPublicSession_feature-L20.pngwebUISharingPublicManagement-sharingPublicSession_feature-L28.pngwebUISharingPublicManagement-sharingPublicSession_feature-L35.pngwebUISharingPublicManagement-sharingPublicSession_feature-L48.png |
Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/23407/37/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L114.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L149.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L181.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L221.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L257.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L266.pngwebUISharingPublicManagement-shareByPublicLink_feature-L19.pngwebUISharingPublicManagement-sharingPublicSession_feature-L10.pngwebUISharingPublicManagement-sharingPublicSession_feature-L20.pngwebUISharingPublicManagement-sharingPublicSession_feature-L28.pngwebUISharingPublicManagement-sharingPublicSession_feature-L35.pngwebUISharingPublicManagement-sharingPublicSession_feature-L48.png |
1ffc38f
to
112bdb6
Compare
Results for oC10Upload https://drone.owncloud.com/owncloud/web/23412/38/1 |
Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/23412/36/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingPublicBasic-publicLinkEdit_feature-L101.pngwebUISharingPublicBasic-publicLinkEdit_feature-L115.pngwebUISharingPublicBasic-publicLinkEdit_feature-L207.pngwebUISharingPublicBasic-publicLinkPublicActions_feature-L18.png |
Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/23412/66/1 |
Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23412/67/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingPublicBasic-publicLinkEdit_feature-L101.pngwebUISharingPublicBasic-publicLinkEdit_feature-L115.pngwebUISharingPublicBasic-publicLinkEdit_feature-L207.pngwebUISharingPublicBasic-publicLinkPublicActions_feature-L18.png |
Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/23412/37/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L114.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L149.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L181.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L221.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L257.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L266.pngwebUISharingPublicManagement-shareByPublicLink_feature-L19.pngwebUISharingPublicManagement-sharingPublicSession_feature-L10.pngwebUISharingPublicManagement-sharingPublicSession_feature-L20.pngwebUISharingPublicManagement-sharingPublicSession_feature-L28.pngwebUISharingPublicManagement-sharingPublicSession_feature-L35.pngwebUISharingPublicManagement-sharingPublicSession_feature-L48.png |
Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/23412/68/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L114.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L149.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L181.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L221.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L257.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L266.pngwebUISharingPublicManagement-shareByPublicLink_feature-L19.pngwebUISharingPublicManagement-sharingPublicSession_feature-L10.pngwebUISharingPublicManagement-sharingPublicSession_feature-L20.pngwebUISharingPublicManagement-sharingPublicSession_feature-L28.pngwebUISharingPublicManagement-sharingPublicSession_feature-L35.pngwebUISharingPublicManagement-sharingPublicSession_feature-L48.png |
Merging #6548 turned quite a bunch of tests green, the remaining ones seem to resolve around tests that run as "the public accesses public link XY" but since the current user never logged out (topbar with avatar stays visible) fail with the screenshot below Sadly, I couldn't find anything in either console nor backend logs |
Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23431/67/1
|
Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23431/69/1
|
remove padding Adjust tag height Add changelog item lowercase beta tag Change bg color for tag Update snapshots Adjustments according to PR review Update changelog/unreleased/enhancement-sidebar-nav-tags Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com> Fix linter Use the new size property of oc-tag
…on type in ODS (#6548) Co-authored-by: Pascal Wengerter <pwengerter@owncloud.com> Fix snapshot test
4fc2469
to
22df1d6
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23440/67/1
|
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: